💉 Inject metadata into signer #3872

WRadoslaw · 2022-11-22T12:42:22Z

Warning
FOR THE QA TEAM
I broke my polkadot wallet a few times while working on this PR. I think this is fixed but when the time comes make sure to backup your accounts before testing it. Also for this reason this PR should be thoroughly tested with all supported browsers and wallets.

vercel · 2022-11-22T12:42:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dao	✅ Ready (Inspect)	Visit Preview	May 19, 2023 8:11am
pioneer-2	✅ Ready (Inspect)	Visit Preview	May 19, 2023 8:11am
pioneer-2-storybook	✅ Ready (Inspect)	Visit Preview	May 19, 2023 8:11am

traumschule · 2022-11-22T16:16:27Z

packages/ui/src/common/hooks/useSignAndSendTransaction.ts

-  const sign = useCallback(() => send('SIGN'), [service])
+  const sign = useCallback(() => {
+    if (wallet && api) {
+      return wallet.updateMetadata(api.chainInfo).then(() => send('SIGN'))


Just for clarification: will this ask the user to update metadata every time a tx is signed or does the signer silently disregard the request if it is the same already?

Yeah, it will be silenced if the version of the specification for given rpc is the same as in the extension

…t-metadata-into-signer

thesan

@WRadoslaw sorry it took me a while to get back to this one.

Nice work! I just made a few changes to still be able to fallback to the original ApiRx in one line change.

Hopefully the CI will pass 🤞

traumschule

Tested here 👍

ivanturlakov · 2023-05-22T13:40:48Z

Tested on https://dao-git-feature-inject-metadata-into-signer-joystream.vercel.app/
Mainnet

@thesan All is works as expected. I am not encountered any problems with updating metadata

Chrome

✅ Polkadot(successfully updated metadata/wallet is ok)
✅ SubWallet(successfully updated metadata/wallet is ok)
✅ Talisman(metadata up to date/app don’t ask to update)

Brave

✅ Polkadot(successfully updated metadata/wallet is ok)
✅ SubWallet(successfully updated metadata/wallet is ok)
✅ Talisman(successfully updated metadata/wallet is ok)

Firefox

✅ Polkadot(successfully updated metadata/wallet is ok)
✅ SubWallet(successfully updated metadata/wallet is ok)
✅ Talisman(successfully updated metadata/wallet is ok)

thesan · 2023-05-30T10:49:29Z

Great work @ivanturlakov 🙌

~~I wasn't expecting it to work with Talisman everywhere. I was just hopping it would not break the wallet.~~
Oh right! it doesn't update on Chrome because it's already up to date...

WRadoslaw added 6 commits November 21, 2022 14:54

New package

f65e10e

Update package

36e3793

Introduce chainInfo into worker

3a3e1a9

Introduce update metadata button into the settings

9c69409

Remove update button from settings

02a1ac0

Check metadata before transaction

4dc101c

WRadoslaw requested a review from thesan November 22, 2022 12:42

WRadoslaw assigned thesan Nov 22, 2022

vercel bot deployed to Preview – pioneer-2-storybook November 22, 2022 12:46 View deployment

Test fix

2d5273a

vercel bot deployed to Preview – pioneer-2-storybook November 22, 2022 14:13 View deployment

vercel bot deployed to Preview – pioneer-2 November 22, 2022 14:14 View deployment

vercel bot deployed to Preview – dao November 22, 2022 14:14 View deployment

traumschule reviewed Nov 22, 2022

View reviewed changes

Test fix

4af15bb

vercel bot deployed to Preview – pioneer-2-storybook November 24, 2022 10:39 View deployment

vercel bot deployed to Preview – pioneer-2 November 24, 2022 10:39 View deployment

vercel bot deployed to Preview – dao November 24, 2022 10:40 View deployment

thesan added 2 commits February 16, 2023 18:46

Keep the ApiRx compatibility

1b1a260

Merge branch 'dev' of github.com:Joystream/pioneer into feature/injec…

1e7832c

…t-metadata-into-signer

vercel bot deployed to Preview – pioneer-2-storybook February 16, 2023 17:53 View deployment

vercel bot deployed to Preview – dao February 16, 2023 17:53 View deployment

vercel bot deployed to Preview – pioneer-2 February 16, 2023 17:53 View deployment

Move type definitions around

bdbd84a

vercel bot deployed to Preview – dao February 16, 2023 18:09 View deployment

vercel bot deployed to Preview – pioneer-2-storybook February 16, 2023 18:09 View deployment

vercel bot deployed to Preview – pioneer-2 February 16, 2023 18:10 View deployment

thesan approved these changes Feb 16, 2023

View reviewed changes

Fix some functions Api types

be564ca

Test new injectweb3-connect build

c8755fe

thesan mentioned this pull request May 3, 2023

Version 2.0.0 WRadoslaw/injectWeb3-connect#4

Open

Fix "Proxy object could not be cloned."

bc93094

thesan force-pushed the feature/inject-metadata-into-signer branch from 14693cc to bc93094 Compare May 3, 2023 13:00

vercel bot deployed to Preview – pioneer-2-storybook May 3, 2023 13:03 View deployment

vercel bot deployed to Preview – pioneer-2 May 3, 2023 13:03 View deployment

vercel bot deployed to Preview – dao May 3, 2023 13:03 View deployment

Fix the chain-metadata serialization

1bd8f99

vercel bot deployed to Preview – pioneer-2-storybook May 4, 2023 15:04 View deployment

vercel bot deployed to Preview – pioneer-2 May 4, 2023 15:04 View deployment

vercel bot deployed to Preview – dao May 4, 2023 15:05 View deployment

traumschule approved these changes May 7, 2023

View reviewed changes

Remove injectweb3-connect archive

d971ca6

vercel bot had a problem deploying to Preview – pioneer-2-storybook May 11, 2023 14:38 Failure

vercel bot had a problem deploying to Preview – dao May 11, 2023 14:38 Failure

vercel bot had a problem deploying to Preview – pioneer-2 May 11, 2023 14:38 Failure

Update injectweb3-connect to 2.1.1

67d97e5

vercel bot deployed to Preview – pioneer-2-storybook May 11, 2023 15:03 View deployment

vercel bot had a problem deploying to Preview – dao May 11, 2023 15:04 Failure

vercel bot had a problem deploying to Preview – pioneer-2 May 11, 2023 15:04 Failure

thesan mentioned this pull request May 19, 2023

Some failing build pass the GitHub CI anyway #4386

Open

Handle webp files in node_modules

acdabff

vercel bot deployed to Preview – pioneer-2-storybook May 19, 2023 08:11 View deployment

vercel bot deployed to Preview – dao May 19, 2023 08:11 View deployment

vercel bot deployed to Preview – pioneer-2 May 19, 2023 08:11 View deployment

thesan merged commit 7c4ffc2 into dev May 30, 2023
1 check passed

thesan deleted the feature/inject-metadata-into-signer branch May 30, 2023 10:53

thesan mentioned this pull request Jun 1, 2023

Add Chain Metadata For Signers #3831

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

💉 Inject metadata into signer #3872

💉 Inject metadata into signer #3872

WRadoslaw commented Nov 22, 2022 •

edited by thesan

Loading

vercel bot commented Nov 22, 2022 •

edited

Loading

traumschule Nov 22, 2022

WRadoslaw Nov 22, 2022

thesan left a comment

traumschule left a comment

ivanturlakov commented May 22, 2023

thesan commented May 30, 2023 •

edited

Loading

💉 Inject metadata into signer #3872

💉 Inject metadata into signer #3872

Conversation

WRadoslaw commented Nov 22, 2022 • edited by thesan Loading

vercel bot commented Nov 22, 2022 • edited Loading

traumschule Nov 22, 2022

Choose a reason for hiding this comment

WRadoslaw Nov 22, 2022

Choose a reason for hiding this comment

thesan left a comment

Choose a reason for hiding this comment

traumschule left a comment

Choose a reason for hiding this comment

ivanturlakov commented May 22, 2023

Chrome

Brave

Firefox

thesan commented May 30, 2023 • edited Loading

WRadoslaw commented Nov 22, 2022 •

edited by thesan

Loading

vercel bot commented Nov 22, 2022 •

edited

Loading

thesan commented May 30, 2023 •

edited

Loading