Fix Forum Loading Screen Text (#4102) #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrlschwb
requested review from
traumschule,
WRadoslaw and
thesan
and removed request for
traumschule,
WRadoslaw and
thesan
traumschule
approved these changes
Apr 5, 2023
traumschule
added
community-dev
thesan
requested changes
Apr 7, 2023
There was a problem hiding this comment.
@chrlschwb adding the loader for the category is definitely an improvement. But similarly to #4318 (review) it doesn't deal with the consequence of the QN being unresponsive these days.
I think checking the error returned by the hook would allow to solve this issue.
Peek.2023-04-07.17-11.webm
…102-LoadingOfForum
traumschule
approved these changes
Apr 11, 2023
thesan
requested changes
Apr 14, 2023
fix message Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #4102