Freeze pallet proposal creation #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
storybook test
thesan
requested changes
Nov 10, 2023
...Proposal/components/SpecificParameters/UpdatePalletFrozenStatus/SelectPalletFrozenStatus.tsx
Outdated
Show resolved
Hide resolved
thesan
reviewed
Nov 10, 2023
|
|
||
| const setPalletFrozenStatus = (selected: PalletFrozenStatus) => { | ||
| if (selected === 'Enabled') { | ||
| setValue('updatePalletFrozenStatus.frozen', true, { shouldValidate: true }) |
There was a problem hiding this comment.
So based on this:
"Enabled" should mean frozen to false and "Disabled" frozen to true
Since a toggle should used instead of a select (see: #4625 (comment)) this isn't so relevant anymore but keep this in mind when labeling the toggle. It's kinda counterintuitive.
thesan
requested changes
Nov 10, 2023
...c/proposals/modals/AddNewProposal/components/SpecificParameters/UpdatePalletFrozenStatus.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/proposals/modals/AddNewProposal/AddNewProposalModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/proposals/modals/AddNewProposal/AddNewProposalModal.tsx
Outdated
Show resolved
Hide resolved
chrlschwb
added
community-dev
thesan
requested changes
Nov 13, 2023
| ...defaultProposalValues, | ||
| updatePalletFrozenStatus: { | ||
| pallet: 'ProjectToken', | ||
| frozen: !palletFrozenStatus, |
There was a problem hiding this comment.
It looks like this doesn't work:
thesan
requested changes
Nov 13, 2023
| @@ -20,3 +20,19 @@ export const isValidCSV = (message: string): Yup.TestConfig<any, AnyObject> => ( | |||
| return true | |||
| }, | |||
| }) | |||
| export const differentFromContext = (msg: string, type?: string): Yup.TestConfig<any, AnyObject> => ({ | |||
There was a problem hiding this comment.
To make things more reusable:
- add a
contextPath: stringargument just like inmaxContextfor example.
Then the validation code becomes:const validationValue = get(this.options.context, contextPath).toJSON() if (validationValue === value) {
- Make the
msginto a function:msg: (value: any) => string.
So the returned message becomes:message: msg(value)
With this differentFromContext becomes:
differentFromContext(
(isFrozen) => `The ProjectToken pallet is currently ${isFrozen ? 'disabled' : enabled}, so presently this proposal would fail due to execution constraints.`,
'palletFrozenStatus',
'execution'
)
thesan
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create proposal for freeze pallet #4557
> Designs
> Story
> Preview
┆Issue is synchronized with this Asana task by Unito