Create freeze pallet proposal design followup #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storybook test
…iew-freeze-pallet-proposal
…e-4557-followup
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thesan
requested changes
Nov 14, 2023
Comment on lines
35
to
39
| <Tooltip tooltipText="You have the flexibility to enable or disable CRT feature."> | ||
| <TooltipDefault /> | ||
| </Tooltip> | ||
| </InlineToggleWrap> | ||
| <ToggleCheckbox |
There was a problem hiding this comment.
Again the goal is to match the design so what happens if you move ToggleCheckbox inside InlineToggleWrap:
Suggested change
| <Tooltip tooltipText="You have the flexibility to enable or disable CRT feature."> | |
| <TooltipDefault /> | |
| </Tooltip> | |
| </InlineToggleWrap> | |
| <ToggleCheckbox | |
| <ToggleCheckbox | |
| falseLabel="Disable" | |
| trueLabel="Enable" | |
| name="updatePalletFrozenStatus.freeze" | |
| id="crt-feature-select" | |
| /> | |
| <Tooltip tooltipText="You have the flexibility to enable or disable CRT feature."> | |
| <TooltipDefault /> | |
| </Tooltip> | |
| </InlineToggleWrap> |
chrlschwb
added
community-dev
thesan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito