This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Add "array" and "error" options #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ var Bluebird = require('bluebird') | |||
|
|
|||
| // Faster `Function.bind()`. | |||
| function bind (fn, ctx) { | |||
| return function bindedFunction () { | |||
| return function boundFunction () { | |||
|
IMHO we are good to go once you squash your commits :) |
array: forces the listener's parameters to be passed as an array rather than a single value. default: undefined error: allows the name of the error event to be specified. default: "error"
Done, thanks :-) |
julien-f
added a commit
that referenced
this pull request
Aug 24, 2015
Add "array" and "error" options.
|
Thank you :) |
|
I'll release it as 0.4.0 as I really don't want to cause any regressions in 0.3. |
|
👍 |
|
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array
forces the listener's parameters to be resolved as an array rather than a single value.
default:
undefinederror
allows the name of the error event to be specified.
default:
"error"