Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Patcher #205

Merged
merged 3 commits into from
Aug 9, 2018
Merged

Update Patcher #205

merged 3 commits into from
Aug 9, 2018

Conversation

rauenzi
Copy link
Member

@rauenzi rauenzi commented Aug 9, 2018

  • Add documentation to patcher.
  • Change how patches are organized to help avoid collisions. Before, if a single called callerA patched render of multiple react components inside discord (which often are just named t) both patchIds would have been identical causing children to go in the wrong location and not actually patch the right component.
  • Allow return of callback for instead and after patches to be the retVal if the callbacks provide it.
  • Add 3rd argument to instead patches which is the original function bound to this which is useful for some patches.
  • Fix leak where children weren't reset on unpatch (super + slaves became children but unpatch still reset super and slaves as opposed to children

@rauenzi
Copy link
Member Author

rauenzi commented Aug 9, 2018

  • Now also normalizes all class names in the DOM at load time since some elements will already be there with their non-normalizes class names

@Jiiks Jiiks merged commit 1288e03 into master Aug 9, 2018
@rauenzi rauenzi mentioned this pull request Aug 9, 2018
@Jiiks Jiiks deleted the patcher branch August 15, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants