Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depredated faraday_middleware #402

Closed

Conversation

tapajos
Copy link
Contributor

@tapajos tapajos commented Aug 5, 2022

Description

Faraday Middleware is now deprecated.

Replace deprecated gzip middleware for faraday-gzip middleware

@tapajos
Copy link
Contributor Author

tapajos commented Aug 5, 2022

Rather than that, is there anything else is blocking to support Faraday 2.0? Anything that I can help?

Copy link
Collaborator

@gaorlov gaorlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for contributing!
Please merge in main to get tests running in the PR and please add this PR to the CHANGELOG.md
Thanks!

@tapajos
Copy link
Contributor Author

tapajos commented Jun 1, 2023

Looks great! thanks for contributing! Please merge in main to get tests running in the PR and please add this PR to the CHANGELOG.md Thanks!

@gaorlov done

@tapajos tapajos requested a review from gaorlov June 1, 2023 17:08
@gaorlov
Copy link
Collaborator

gaorlov commented Jun 5, 2023

@tapajos looks like there's issues with the tests. can you take a look please?
Thanks!

@lavoiesl
Copy link
Contributor

lavoiesl commented May 2, 2024

Included in #412 and a mention was added in the CHANGELOG

@tapajos
Copy link
Contributor Author

tapajos commented May 6, 2024

Closing since it was included in #412

@tapajos tapajos closed this May 6, 2024
@tapajos tapajos deleted the remove_faraday_middleware branch May 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants