Case insensitive schema dict #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix order bug due to usage of sets in xpath construction (list conversion from set does not guarantee order)
…schema_parser functions is deteministic
… pprint has an option to sort dict keys in python 3.8+, which should also work with UserDicts. I will keep this in mind
…that the attribute xpaths now contain the attribute names also moved hte tag_name option of evaluate_attribute to get_attrib_xpath
… dict, check type of the changed keys explicitely
Codecov Report
@@ Coverage Diff @@
## develop #15 +/- ##
===========================================
+ Coverage 70.60% 71.28% +0.68%
===========================================
Files 68 71 +3
Lines 8915 9141 +226
===========================================
+ Hits 6294 6516 +222
- Misses 2621 2625 +4 |
…oing them otherwise a frozenset will come out
added complex entry with tags not in simple
…duce the same result
…se of the objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
fleur_schema_parser_functions.pynow use sets to make duplicate handling easiertag_nameoption from evaluate_attribute toget_attrib_xpathTODO:
get_tag_xpathandget_attrib_xpathtests to include case insensitivity