Make sure that values in `convert_to_xml` are not `None` #182

janssenhenning · 2022-07-21T11:46:56Z

Triggering example

from masci_tools.io.fleurxmlmodifier import FleurXMLModifier

fm = FleurXMLModifier()
fm.set_inpchanges({'forcealpha': None})
fm.modify_xmlfile('inp.xml')

codecov · 2022-07-21T11:51:17Z

Codecov Report

Merging #182 (b47123f) into develop (e82ad70) will decrease coverage by 0.00%.
The diff coverage is 94.11%.

@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
- Coverage    86.58%   86.58%   -0.01%     
===========================================
  Files          135      135              
  Lines        24368    24372       +4     
===========================================
+ Hits         21100    21103       +3     
- Misses        3268     3269       +1

Make sure that values in convert_to_xml are not None

72831ef

Remove list_return argument from eval_xpath_create

c84391a

janssenhenning force-pushed the fix/passing-none-to-xml-converters branch from d49975e to c84391a Compare July 21, 2022 12:17

Revert change accidentally breaking tests

b47123f

janssenhenning merged commit fa5cbaa into develop Jul 21, 2022

janssenhenning deleted the fix/passing-none-to-xml-converters branch July 21, 2022 12:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure that values in `convert_to_xml` are not `None` #182

Make sure that values in `convert_to_xml` are not `None` #182

janssenhenning commented Jul 21, 2022

codecov bot commented Jul 21, 2022 •

edited

Make sure that values in convert_to_xml are not None #182

Make sure that values in convert_to_xml are not None #182

Conversation

janssenhenning commented Jul 21, 2022

codecov bot commented Jul 21, 2022 • edited

Codecov Report

Make sure that values in `convert_to_xml` are not `None` #182

Make sure that values in `convert_to_xml` are not `None` #182

codecov bot commented Jul 21, 2022 •

edited