Move fleur schema folder #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the fleur_schema can be imported without touching the fleur parsers. This solves a whole range of circular import issues
The only places, where we still need the TYPE_CHECKING flag is the xml/common_functions and converters since these are explicitely used in the fleur_schema subpackage
Codecov Report
@@ Coverage Diff @@
## develop #87 +/- ##
===========================================
+ Coverage 80.17% 80.20% +0.02%
===========================================
Files 120 121 +1
Lines 21643 21642 -1
===========================================
+ Hits 17353 17357 +4
+ Misses 4290 4285 -5 |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the folder
masci_tools/io/parsers/fleur/fleur_schematomasci_tools/io/parsers/fleur_schema. Otherwise it is impossible to import the SchemaDict types without importing the fleur file parsers. THis means that no function used in the file parsers can directly depend on the SchemaDict without creating a range of subtle possibilities for circular import issues.The old imports are still supported with a stub init file and emit a DeprecationWarning