Allow to use vpr even if you are not in the root directory #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt
commented
Oct 20, 2019
| return dir if File.directory?(File.join(dir, '.git')) | ||
|
|
||
| parent = File.dirname(dir) | ||
| return dir if parent == dir # we're at the root |
There was a problem hiding this comment.
needed to abort, when we cannot go any further to avoid endless loops.
schmidt
commented
Oct 20, 2019
Comment on lines
+38
to
+40
| # TODO: replace with a human readable error message and a non-zero exit | ||
| # code | ||
| expect { described_class.repo_url }.to raise_error(ArgumentError) |
There was a problem hiding this comment.
In the future, it would be nice if such an exception would result in a proper error message.
Before executing git related commands, vpr will explicitly look for the `.git` directory in the current directory and each of it's parent, stopping at the earliest match. This way, similar to the git command line tools, vpr may be used in sub folders. If vpr cannot find a `.git` directory in any of the parents, then it falls back to using the current directory.
This was referenced Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before executing git related commands, vpr will explicitly look for the
.gitdirectory in the current directory and each of it's parent, stopping at the earliest match. This way, similar to the git command line tools, vpr may be used in sub folders.If vpr cannot find a
.gitdirectory in any of the parents, then it falls back to using the current directory.