Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to add rounded corners to skeleton views #13

Closed
virtualrapha opened this issue Nov 21, 2017 · 5 comments
Closed

Possibility to add rounded corners to skeleton views #13

virtualrapha opened this issue Nov 21, 2017 · 5 comments

Comments

@virtualrapha
Copy link

Hi,

in the README, all screenshots show skeleton views with sharp corners. Is it possible to provide a corder radius so that the grey views have rounded corners?

@manuel21
Copy link

This featured will be awesome!

@Juanpe
Copy link
Owner

Juanpe commented Nov 22, 2017

Hi @raphaklr and @manuel21, actually the round corners are allowed. If you view has corner the skeleton will draw with corner too.

For example, with this code:

@IBOutlet weak var avatarImage: UIImageView! {
    didSet {
        avatarImage.layer.cornerRadius = avatarImage.frame.width/2
        avatarImage.layer.masksToBounds = true
    }
}

The result is:
screen shot 2017-11-22 at 08 51 21

@virtualrapha
Copy link
Author

virtualrapha commented Nov 22, 2017

@Juanpe thanks for the answer. But is it possible to have rounded corners in the skeleton view, while the actual views have sharp edges? I'm looking for something like this:

bildschirmfoto 2017-11-22 um 09 07 20

@Juanpe
Copy link
Owner

Juanpe commented Nov 22, 2017

Mm...not, today it's not possible. I'm going to add this feature in the backlog, ok?
Thanks!

@virtualrapha virtualrapha changed the title Possibility to add rounded corner to skeleton views Possibility to add rounded corners to skeleton views Nov 25, 2017
@Juanpe
Copy link
Owner

Juanpe commented May 9, 2019

Closed this issue, corner radius are available since version 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants