Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an access point for projects to edit SkeletonDefaultConfig #83

Closed
reececomo opened this issue Aug 2, 2018 · 1 comment
Closed

Provide an access point for projects to edit SkeletonDefaultConfig #83

reececomo opened this issue Aug 2, 2018 · 1 comment
Labels
💡 enhancement

Comments

@reececomo
Copy link
Contributor

What did you do?

Went to set the defaults

What did you expect to happen?

The defaults would be set

What happened instead?

Was not able to set the defaults because they are static immutables 😂

Steps to reproduce the behavior

Try to set the defaults
reececomo added a commit to reececomo/SkeletonView that referenced this issue Aug 2, 2018
@reececomo
Juanpe#83 Customisable Defaults
af91af3
reececomo added a commit to reececomo/SkeletonView that referenced this issue Aug 2, 2018
@reececomo
Merge pull request #1 from reececomo/83-Customisable-Defaults
0eff052 
Juanpe#83 Customisable Defaults
Juanpe added a commit that referenced this issue Aug 2, 2018
@Juanpe
Merge pull request #84 from reececomo/83-Customisable-Defaults
3bf613d 
#83 Customisable Defaults
@Juanpe
Copy link
Owner

Juanpe commented Aug 2, 2018

Done in the latest version 1.3

@Juanpe Juanpe closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Juanpe @reececomo