[BugFix] Fix issue on WKWebView/UIWebView #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulanatoleclaudot-betclic
changed the title
Juanpe
reviewed
Apr 23, 2020
| @@ -94,6 +94,7 @@ public extension UIView { | |||
|
|
|||
| extension UIView { | |||
| @objc func skeletonLayoutSubviews() { | |||
| guard Thread.isMainThread else { return } | |||
There was a problem hiding this comment.
I think this guard should be after the skeletonLayoutSubviews method. Here, the original layoutSubviews method will not be called.
There was a problem hiding this comment.
The stacktrace shows us that the issue came from the skeletonLayoutSubviews. We should "kill" it as soon as possible, so in the first call (not in the child view, which gonna have the same thread issue), what do you think ?
In any case, this should not be called on another thread but the main one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes and for unknown reason, WKWebview/UIWebView calls skeletonLayoutSubviews not on the main thread, which causing NSISEngine to crash
Fatal Exception:
NSInternalInconsistencyException Modifications to the layout engine must not be performed from a background thread after it has been accessed from the main thread.
Fatal Exception: NSInternalInconsistencyException
0 CoreFoundation 0x18d17096c __exceptionPreprocess
1 libobjc.A.dylib 0x18ce89028 objc_exception_throw
2 Foundation 0x18d65c5e0 -[NSISEngine tryToOptimizeReturningMutuallyExclusiveConstraints]
3 Foundation 0x18d455854 -[NSISEngine _optimizeWithoutRebuilding]
4 Foundation 0x18d455768 -[NSISEngine optimize]
5 Foundation 0x18d4553d8 -[NSISEngine performPendingChangeNotifications]
6 UIKitCore 0x1917115b8 -[UIView(Hierarchy) layoutSubviews]
7 SkeletonView 0x1018458d4 @objc UIView.skeletonLayoutSubviews() + 98 (SkeletonView.swift:98)
Crashed: WebThread
SIGABRT ABORT 0x000000018cf5aefc