Fixed: UITextField placeholder text is visible while skeleton is showing #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing Juanpe#345 Setting placeholder to nil on prepareViewForSkeleton() method Created RecoverableTextFieldState, which has textColor and placeholder properties, Added UITextField extension in Recoverable.swift, setting the values on recoverViewStage 'forced' is true
|
Hi @keshavamurthy1, please, could you update your branch, it seems something is failing. I've updated the CI system, so it's possible that your branch works fine |
Juanpe
changed the title
|
@Juanpe done, all checks are passed now. |
|
Yeah, now it looks great 🤙 Thanks again for contributing ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #345
Setting placeholder to nil on prepareViewForSkeleton() method
Created RecoverableTextFieldState, which has textColor and placeholder properties,
Added UITextField extension in Recoverable.swift
Setting the values back to UITextField properties on recoverViewStage method with 'forced' parameter is true
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an
xin each of the[ ])