Fixed: SkeletonView respecting Font's height, rather than the `UIView… #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` actual height Juanpe#353 Using Label height from the HeightConstraint if there is any instead of the Label Font line height if no HeightConstraint set, will be using SkeletonAppearance.default.multilineHeight as it was before
|
Nice. 👏 |
|
Hi @keshavamurthy1 thanks for contributing :) |
Juanpe
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…` actual height #353
Summary
Fixed #353
Using Label height from the HeightConstraint if there is any HeightConstraint set instead of the Label Font line height
if no HeightConstraint set, will be using SkeletonAppearance.default.multilineHeight as it was before
Requirements (place an
xin each of the[ ])