Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepareCellForSkeleton for UITableView and UICollectionView #415

Conversation

nemanjachoco
Copy link
Contributor

@nemanjachoco nemanjachoco commented Jun 23, 2021

Summary

This is a continuation of #413

Fixes #412

Requirements

@nemanjachoco nemanjachoco marked this pull request as ready for review June 23, 2021 17:16
@nemanjachoco
Copy link
Contributor Author

@Juanpe Sorry it is a different PR, but it is done now. Please let me know what do you think.

Copy link
Owner

@Juanpe Juanpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left just a comment. The rest of the code LGTM 😄

Good job 👌🏼

README.md Outdated Show resolved Hide resolved
@Juanpe
Copy link
Owner

Juanpe commented Jun 23, 2021

When the changes are done, I'll merge this PR and release a new version with both new features 🎉

@Juanpe Juanpe added the feature label Jun 23, 2021
Co-authored-by: Juanpe Catalán <juanpecm@gmail.com>
@nemanjachoco
Copy link
Contributor Author

Thanks! Looking forward to using this soon :)

@github-actions
Copy link

Warnings
⚠️

Consider also updating the README for other languages.

Generated by 🚫 Danger Swift against 775c64a

@Juanpe Juanpe changed the title Add prepareCellForSkeleton for UITableView and UICollectionView Add prepareCellForSkeleton for UITableView and UICollectionView Jun 24, 2021
@Juanpe Juanpe merged commit 9fccaf4 into Juanpe:main Jun 24, 2021
@nemanjachoco nemanjachoco deleted the feature/configureCellTableViewAndCollectionView branch June 24, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Cell Feature
2 participants