Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug 426 #427

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix for bug 426 #427

merged 1 commit into from
Aug 19, 2021

Conversation

ankitagarwal007
Copy link
Contributor

@ankitagarwal007 ankitagarwal007 commented Aug 9, 2021

Summary

Closes #426

Requirements (place an x in each of the [ ])

@Juanpe
Copy link
Owner

Juanpe commented Aug 17, 2021

Hi @ankitagarwal007 👋🏼

I was thinking about this PR and I think we should allow to the developers deciding if the library should use the font line for labels or not. So, I think we could create a new property, something like usesTextHeightForLabels. WDTY?

@Juanpe
Copy link
Owner

Juanpe commented Aug 19, 2021

Congratulations! 🎉 This was released as part of SkeletonView 1.23.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The UILabel doesn't consider the font line height while showing skeleton
2 participants