Fix animation when the transition is .none
#481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndtoan75
pushed a commit
to notabasement/SkeletonView
that referenced
this pull request
Jul 5, 2022
* main: (276 commits) Add Swift Package Index badge for platforms Bump version 1.29.3 Bump cocoapods-downloader from 1.2.2 to 1.6.3 (Juanpe#497) Bump version 1.29.2 Fix crash when text is empty (Juanpe#483) Update CD.yml Update stale.yml Bump version 1.29.1 Fix animation when the transition is `.none` (Juanpe#481) Bump version 1.29.0 Create new `SkeletonGradient constructor (Juanpe#480) Update CD.yml Bump version 1.28.0 Improved number of lines calculation (Juanpe#479) Update CD.yml Bump version 1.27.0 Add skeletonCornerRadius in SkeletonAppearance (Juanpe#478) Update CD.yml Bump version 1.26.2 Fix last line text alignment when using padding insets (Juanpe#477) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #459
Summary
When the skeleton appears without transition the constraints are animated too. This solution enqueues the completion in the main thread.