Bug: CGColor from dynamic UIColor #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
|
Is there any plan to merge this PR please ? |
|
Hi @Dolphin54rus! thanks for contributing. LGTM 🎉 |
Juanpe
approved these changes
Sep 5, 2022
ndtoan75
pushed a commit
to notabasement/SkeletonView
that referenced
this pull request
Sep 23, 2022
…upstream_version_1.30.2 * commit '6604aae9899987206c3a99607c0549a46d3f35a4': Bump version 1.30.2 Fix "complementaryColor" color isn't changed after updating the application theme (Juanpe#496) Update Stale action Create needs-attention.yml Bump version 1.30.1 Bugfix/tableview insetgrouped (Juanpe#494) Update README.md Revert changes in the Package file Testing XCFramework Bump version 1.30.0 Add prepareViewForSkeleton to SkeletonCollectionViewDataSource (Juanpe#505) Bump version 1.29.4 Bump tzinfo from 1.2.5 to 1.2.10 (Juanpe#507)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #487
Summary
When CGColor was taken from a dynamic UIColor the system theme was always used.
Before:
After:
Requirements (place an
xin each of the[ ])