Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Header #409

Open
slowbot opened this issue Aug 13, 2020 · 0 comments
Open

Base Header #409

slowbot opened this issue Aug 13, 2020 · 0 comments

Comments

@slowbot
Copy link
Contributor

slowbot commented Aug 13, 2020

Base Header

  • Nested

    • Global Bar
    • Nav Primary Base
      • Variants
        • Simple
        • Mega
  • Variants

    • Height
      • Basic
      • Extended
    • Background
      • Default
      • Inverted
  • Notes

    • CSS is organized to mirror the structure of the original usa components reading order
    • Logos are currently svgs. I did not use the sprite because I was assuming these would be uploaded via the admin. I include multiple form factors for each logo for header and footer placements as well as mobile.
    • Secondary nav in header is positioned outside of header hat so it can conform to mobile layout.
    • Started to extract repeating variables
    • Isolated inverted values, we can talk about a more elegant way to do this.
    • Had to make some modifications to mobile navigation. PL only styles account for header offset. Relocated close button to account for design.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant