Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shallow copy hack, if jsoneditor provide a way to do so. #1

Closed
tomalec opened this issue Jun 10, 2014 · 0 comments
Closed

Remove shallow copy hack, if jsoneditor provide a way to do so. #1

tomalec opened this issue Jun 10, 2014 · 0 comments

Comments

@tomalec
Copy link
Member

tomalec commented Jun 10, 2014

Currently at /src/juicy-jsoneditor.html#L41 I need to iterate over json's properties to replace/remove them with ones from JSONEditor.

First of all it replaces entire objects, so it will break any binding to nested nodes, it triggers update on all root nodes even if they were not changed.

All that ugly hacking would not be necessary if JSONEditor's change callback could provide actual changes. (josdejong/jsoneditor#102)

tomalec added a commit that referenced this issue Oct 3, 2014
@tomalec tomalec closed this as completed in dc2f1e3 Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant