Count extended fingers & build path modification #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing since you haven't expressed any interest in this, if at a later point you'd like to implement these would love to talk then! |
|
My apologies, I didn't get a chance to look into it yet! Thanks! |
|
No worries whatsoever! Just figured I wouldn't leave an open ended PR if you were busy with other things 馃槂. If you get a chance to have a look and have any questions please let me know! |
|
It looks straightforward so I merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using your patch for a school project and have found it incredibly valuable, thank you so much for making it! If you're interested here are two commits that I think would make using the patch a slightly nicer experience. The two are completely unconnected and can be cherry picked if you would like one but not the other (assuming you want either at all). A little more detail on each commit:
Count extended fingers only- currently thenumfingersvalue output by the patch is always as many fingers as one has on their hand (for me always five, don't have any friends with less fingers to test with 馃槃 ). I needed to count the number of extended fingers in the course of my project so I addedextended()to the patch to do so (apologies if you're aware of this and purposely wanted total number of fingers vs extended).Generate target in repo root- changes the target path to generate the patch at the root of the repo. This one is definitely opinionated, I found it slightly confusing that the build process generated a target outside the repo and in a max5 folder. I think generating it to the root might be a little more clear to users what they've generated.Thanks again for making such a helpful tool! Please let me know if there's anything you'd like from me to help this pull request go through!