New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor `lrp!` #70

Merged

adrhill merged 4 commits into master from ah/refactor-lrp

May 25, 2022

Member

adrhill commented May 25, 2022

This PR is breaking as it

makes Rₖ₊₁ the first argument of lrp!, matching Julia's Bang convention
changes rule keyword-arguments to default arguments, removing the need for users to type unicode symbols
adds type stability fix for GammaRule

adrhill added 4 commits

May 25, 2022 20:03


          Type stability fixes and default args instead of kwargs

d4a2c0c


          Make Rₖ₊₁ first argument of lrp!, matching Bang convention

ae365cf


          Add explanations for non-Julia programmers to docs

78497b3


          Update tests for new GammaRule

2856e85

adrhill merged commit 16119c4 into master

adrhill deleted the ah/refactor-lrp branch

May 25, 2022 18:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment