Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast FlatRule #96

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fast FlatRule #96

merged 1 commit into from
Aug 19, 2022

Conversation

adrhill
Copy link
Member

@adrhill adrhill commented Aug 19, 2022

In local tests, this was ~1000x faster:

                                                    ID                 time ratio               memory ratio
  –––––––––––––––––––––––––––––––––––––––––––––––––––– –––––––––––––––––––––––––– ––––––––––––––––––––––––––
                        ["Layer", "Dense", "FlatRule"] 0.00 (5%) :whitecheckmark: 0.00 (1%) :whitecheckmark:

going from 46.238 μs

                                                    ID            time    GC time          memory allocations
  –––––––––––––––––––––––––––––––––––––––––––––––––––– ––––––––––––––– –––––––––– ––––––––––––––– –––––––––––

                        ["Layer", "Dense", "FlatRule"]  46.238 μs (5%)            200.02 KiB (1%)          11

to 48.798 ns:

                                                    ID            time    GC time          memory allocations
  –––––––––––––––––––––––––––––––––––––––––––––––––––– ––––––––––––––– –––––––––– ––––––––––––––– –––––––––––

                        ["Layer", "Dense", "FlatRule"]  48.798 ns (5%)                                       

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #96 (c42dbce) into master (185cd64) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   95.31%   95.36%   +0.04%     
==========================================
  Files          16       16              
  Lines         576      582       +6     
==========================================
+ Hits          549      555       +6     
  Misses         27       27              
Impacted Files Coverage Δ
src/lrp/rules.jl 97.40% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adrhill adrhill merged commit f5970b6 into master Aug 19, 2022
@adrhill adrhill deleted the ah/fast-flat branch August 19, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants