Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show() in scikitlearnAPI.jl write to standard out instead of io stream #103

Closed
kvantitative opened this issue Sep 26, 2019 · 2 comments
Closed

Comments

@kvantitative
Copy link

The function show is used to print out the decision trees. It takes a IO stream as a input, and write out the decision tree to this input. The IO stream is argument io to the function.

However, some of the output is written to the standard output instead of to the IO stream. Normally this is not an big issue, since the IO stream is pointing to standard output anyway, but when you uses the Juno IDE the output is messed up.

The function show is found in line 76-86 in scikitlearnAPI.jl, in v 0.8.3. Line 84-85 is:
print(io, "classes: ") ; show(dt.classes) ; println()
print(io, "root: ") ; show(dt.root)

but should be:
print(io, "classes: ") ; show(io,dt.classes) ; println(io,"")
print(io, "root: ") ; show(io,dt.root)

@JuliaAI JuliaAI deleted a comment from JuliaRegistrator Sep 28, 2019
@JuliaAI JuliaAI deleted a comment from JuliaRegistrator Sep 28, 2019
@bensadeghi
Copy link
Member

@kvantitative
Thanks for catching this. I think the issue should be resolved now
Please give it a test try once v0.8.4 is available in the package registry (in a day or so)

@kvantitative
Copy link
Author

Hi bensadeghi,
Looks fine to me! - and thanks for a great package.

giopaglia pushed a commit to giopaglia/ModalDecisionTrees.jl that referenced this issue Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants