Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature importance #182

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Feature importance #182

merged 1 commit into from
Jun 30, 2022

Conversation

yufongpeng
Copy link
Collaborator

Clean commits from #166

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #182 (3d0f314) into dev (be7a715) will increase coverage by 0.20%.
The diff coverage is 93.13%.

@@            Coverage Diff             @@
##              dev     #182      +/-   ##
==========================================
+ Coverage   89.34%   89.54%   +0.20%     
==========================================
  Files          10       10              
  Lines        1004     1177     +173     
==========================================
+ Hits          897     1054     +157     
- Misses        107      123      +16     
Impacted Files Coverage Δ
src/util.jl 92.18% <ø> (ø)
src/DecisionTree.jl 51.51% <57.89%> (-3.59%) ⬇️
src/regression/main.jl 92.00% <88.23%> (-2.74%) ⬇️
src/measures.jl 97.23% <95.74%> (-0.42%) ⬇️
src/scikitlearnAPI.jl 50.42% <96.42%> (+10.83%) ⬆️
src/classification/main.jl 97.89% <98.83%> (+0.27%) ⬆️
src/abstract_trees.jl 100.00% <100.00%> (ø)
src/classification/tree.jl 100.00% <100.00%> (ø)
src/regression/tree.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7a715...3d0f314. Read the comment docs.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yufongpeng Thanks for this substantial contribution.

@yufongpeng
Copy link
Collaborator Author

Thanks for the opinions on this PR. l'm happy it is finally done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants