Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "algorithm" instead of "model" and dispatch predict on kind of target proxy #17

Merged
merged 9 commits into from
Mar 2, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Mar 2, 2023

Closes #12 and #14.

In this PR:

  • Rename the structs that store the hyperparameters of some ML/statistics algorithm, algorithms (previously models)
  • Remove predict_joint method, as redundant under changes below
  • TargetProxy abstract type is renamed KindOfProxy
  • Make predict for target variable or target proxy only (transform is for anything else) and add argument to predict to allow dispatch on the kind of target proxy. In this way algorithms can implement predict for multiple kinds of target proxy, although we now require declaration of a preferred kind (new preferred_kind_of_proxy trait).
  • Remove traits for input/output type/scitype of inverse_transform; I figure these can just be inferred from the transform traits.
  • Update all associated documentation

@ablaom ablaom merged commit d6b394e into dev Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use "model" to describe hyperparameter struct.
1 participant