Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control verbosity of @load macro #192

Closed
juliohm opened this issue Jul 30, 2019 · 2 comments · Fixed by #196
Closed

Control verbosity of @load macro #192

juliohm opened this issue Jul 30, 2019 · 2 comments · Fixed by #196

Comments

@juliohm
Copy link
Contributor

juliohm commented Jul 30, 2019

Is your feature request related to a problem? Please describe.
Whenever I load a model in a script, I get verbose information about the packages being loaded.

Describe the solution you'd like
I would like to control this verbosity, possibly by using an alternative macro. @load would be quiet, and then @loaddbg would print information about package imports.

Describe alternatives you've considered
An alternative would be to make @load quiet, and to not introduce a @loaddbg.

Additional context
The context is normal usage. I would like to try out a couple of models in a problem, and the messages printed can get annoying quickly.

@ablaom
Copy link
Member

ablaom commented Jul 30, 2019

Sounds good idea to me. Suggested syntax:

@load PCA verbosity=0

We use "verbosity" levels elsewhere in the interface, rather than "silent".

PR welcome.

@juliohm
Copy link
Contributor Author

juliohm commented Jul 30, 2019

I would make this verbosity option 0 by default. Then users interested in the messages can pass verbosity=1 or higher.

Will try submit a PR.

juliohm added a commit to juliohm/MLJ.jl that referenced this issue Jul 31, 2019
juliohm added a commit to juliohm/MLJ.jl that referenced this issue Jul 31, 2019
ablaom added a commit that referenced this issue Jul 31, 2019
Fix #192: Add verbosity option to @load macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants