Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New measures RSquared and aliases rsq, rsquared need exporting #880

Closed
ablaom opened this issue Dec 29, 2021 · 3 comments · Fixed by #887
Closed

New measures RSquared and aliases rsq, rsquared need exporting #880

ablaom opened this issue Dec 29, 2021 · 3 comments · Fixed by #887
Labels

Comments

@ablaom
Copy link
Member

ablaom commented Dec 29, 2021

Or we should export measures in a more programmatic way.

@sayantan1410
Copy link
Contributor

Hello, I would like to contribute to this issue, can you please explain a bit more on what is to be done ?

@ablaom
Copy link
Member Author

ablaom commented Jan 6, 2022

Well, the dead easy option is just to add RSquared, rsq, rsquared to the list here, just like we already have in the source package here. I'd be perfectly happy with this.

On the other hand, if you know some julia metaprogramming, you could replace the current nonsense with something more programmatic, so we don't have to keep adding to the list every time a new measure is added to MLJBase. Once MLJBase is imported, you can do measures() to get a table of all the measures and their properties, the relevant ones being name and instances (aliases) which you are going to interpolate into some eval(:(export $name)) calls, or whatever. You can find an example of this kind of thing here.
In this case you may need to re-arrange code so that the import calls happen before the export calls, if that isn't already the case.

@sayantan1410
Copy link
Contributor

@ablaom Thank you so much, I will try to solve it in the better way possible. Will drop in a comment if I face some issue or have some problem in understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants