Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recent measures to src/MLJ.jl #887

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Added recent measures to src/MLJ.jl #887

merged 2 commits into from
Jan 17, 2022

Conversation

sayantan1410
Copy link
Contributor

Fix #880
Sorry, I tried to do it in the optimum way but as I am new to the repository and also this is my first PR to this repository, so I was little bit scared. Once get a little bit more familiar to the codebase, I wish to come back to it.
let me know if I made any mistake.
@ablaom

src/MLJ.jl Outdated Show resolved Hide resolved
Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayantan1410 Thank you very much for this.

Yes, that's a good idea to make a simple PR first.

Just the minor formatting comment and othewise good.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022

Codecov Report

Merging #887 (76ff4be) into dev (3e55229) will not change coverage.
The diff coverage is n/a.

❗ Current head 76ff4be differs from pull request most recent head 9c643d3. Consider uploading reports for the commit 9c643d3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #887   +/-   ##
=======================================
  Coverage   42.85%   42.85%           
=======================================
  Files           1        1           
  Lines          28       28           
=======================================
  Hits           12       12           
  Misses         16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e55229...9c643d3. Read the comment docs.

@sayantan1410
Copy link
Contributor Author

Sure I will make the change ASAP
Thank you @ablaom

@sayantan1410
Copy link
Contributor Author

@ablaom just mentioning you here, incase you haven't noticed the changes.

@ablaom
Copy link
Member

ablaom commented Jan 17, 2022

Thanks for patience. Just back from leave.

@ablaom ablaom merged commit 9955b47 into JuliaAI:dev Jan 17, 2022
@sayantan1410
Copy link
Contributor Author

That's all right, hope you had a great leave and thanks for merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New measures RSquared and aliases rsq, rsquared need exporting
3 participants