Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the goal of improving test coverage of the whole library, I'm starting from the file I've already worked on,
tasks.jl
. I also started using@test_logs
, to actually test the content of the log messages, making the tests visually less noisy and in the end more robust.Thanks to test coverage I also realised that there were a couple of
coerce
methods that were not actually being called because of wrong signature: the default less efficient methods were being called instead, but the result was correct in any case.The only line that is not tested is the very last one, the
unsupervised
function, I'm not sure what could be a good test for it.