Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of tasks.jl #135

Merged
merged 2 commits into from
May 21, 2019
Merged

Conversation

giordano
Copy link
Member

With the goal of improving test coverage of the whole library, I'm starting from the file I've already worked on, tasks.jl. I also started using @test_logs, to actually test the content of the log messages, making the tests visually less noisy and in the end more robust.

Thanks to test coverage I also realised that there were a couple of coerce methods that were not actually being called because of wrong signature: the default less efficient methods were being called instead, but the result was correct in any case.

The only line that is not tested is the very last one, the unsupervised function, I'm not sure what could be a good test for it.

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.92%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage    69.1%   70.02%   +0.92%     
==========================================
  Files          18       18              
  Lines        1191     1191              
==========================================
+ Hits          823      834      +11     
+ Misses        368      357      -11
Impacted Files Coverage Δ
src/tasks.jl 96.61% <100%> (+18.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d0443...936b183. Read the comment docs.

@ablaom
Copy link
Member

ablaom commented May 21, 2019

Thanks for that! Looks good to me.

@ablaom ablaom merged commit d636720 into JuliaAI:master May 21, 2019
@giordano giordano deleted the test-logs branch May 21, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants