Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rng to resampling methods (cv and holdout) #179

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

ayush-1506
Copy link
Collaborator

Fixes : #178.
This will also involve a small addition in MLJBase. Will open a PR to include that.

@codecov-io
Copy link

Codecov Report

Merging #179 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   70.99%   70.97%   -0.02%     
==========================================
  Files          19       19              
  Lines        1403     1409       +6     
==========================================
+ Hits          996     1000       +4     
- Misses        407      409       +2
Impacted Files Coverage Δ
src/resampling.jl 83.48% <80%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6f2f5...19f9dd8. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jul 14, 2019

Codecov Report

Merging #179 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   70.99%   70.97%   -0.02%     
==========================================
  Files          19       19              
  Lines        1403     1409       +6     
==========================================
+ Hits          996     1000       +4     
- Misses        407      409       +2
Impacted Files Coverage Δ
src/resampling.jl 83.48% <80%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6f2f5...19f9dd8. Read the comment docs.

@ayush-1506
Copy link
Collaborator Author

@ablaom Tests pass now.

@ablaom ablaom merged commit e7aeeb4 into JuliaAI:master Jul 15, 2019
@ablaom
Copy link
Member

ablaom commented Jul 15, 2019

Thanks @ayush-1506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resampling strategies should have option for independent RNG
3 participants