Update to MLJBase 0.4.0 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make compatible with MLJBase 0.4
update Registry Project.toml: [compat] MLJBase="0.4", MLJModels="0.3" Update metadata decoding to work properly with Table scitypes, etc
|
Once MLJModels 0.3.0 is registered, this PR should pass travis and be ready to merge. |
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 69.67% 69.39% -0.28%
==========================================
Files 20 20
Lines 1596 1552 -44
==========================================
- Hits 1112 1077 -35
+ Misses 484 475 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are mostly concerned with adjusting model trait definitions, as described in this MLJBase PR. Changes relevant to the general user:
Doc strings and the manual have been revised and updated. The manual includes a new section "Tuning models", and extra material under "Learning networks" explaining how to export learning networks as stand-alone models using the
@from_networkmacro.Improved checks and error-reporting for binding models to data in machines.
(Breaking) CSV is now an optional dependency, which means you now need to import CSV before you can load tasks with
load_boston(),load_iris(),load_crabs(),load_ames(),load_reduced_ames()Added
schemamethod for tables (re-exported from ScientificTypes.jl). Returns a named tuple with keys:names,:typesand:scitypes.(Breaking) Eliminate
scitypesmethod. The scientific types of a table are returned as part of ScientificTypesschemamethod (see above)