Clean up export of measure-related methods #892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs:
This PR does the following (which includes resolution of #890):
re-organizes src/MLJ.jl to have order: imports, definition of global constants, include files, exports
cleans up export of measure-related exports by using new constant
MLJBase.MEASURE_TYPES_ALIASES_AND_INSTANCES
and some meta-programming; some forgotten measure names are re-exported as a result (see below)cleans up export of traits (for models and measures) by exporting almost all of MLJ.MLJBase.StatisticalTraits.TRAITS programatically. This results in a large number of new trait exports, which I don't think will do any harm, but will make things less confusing to users. The exceptions are listed in the following new global constant:
All previously exported methods are exported - I have explicitly checked this with
names(MLJ)
(one exception was a name with no corresponding methods,rmsl1
). The following are the new exports: