Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated names of BetaML models #968

Merged
merged 11 commits into from
Oct 26, 2022
Merged

Updated names of BetaML models #968

merged 11 commits into from
Oct 26, 2022

Conversation

sylvaticus
Copy link
Contributor

No description provided.

@ablaom
Copy link
Member

ablaom commented Oct 5, 2022

@sylvaticus Thanks. We normally make all new PRs onto dev, the default branch. Can you please rebase?

@sylvaticus sylvaticus changed the base branch from master to dev October 6, 2022 04:09
@sylvaticus
Copy link
Contributor Author

it should have been rebased now... or so I think..

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ablaom ablaom merged commit ffa2c22 into JuliaAI:dev Oct 26, 2022
@sylvaticus
Copy link
Contributor Author

Hello, something didn't work well with this PR.. the List of supported models (dev) page is still referring to the very old BetaML-MLJ interface names...

(minor typo: also in the meantime I realised there is no MultitargetGaussianMixtureImputer)

@ablaom
Copy link
Member

ablaom commented Nov 29, 2022

Yeah, that page has to be updated manually. Thanks for pointing this out.

#993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants