Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload all operations (predict, predict_mode, etc) for use on Static machines #813

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jul 25, 2022

At present only transform is overloaded. In clustering algorithms that do not generalize to new data, such as DBSCAN, we also need predict, for consistency with clustering models that do generalize (as transform is "reserved" for dimension reduction). This PR overloads all operations that can be called on Static models to work for Static machines as well.

@ablaom ablaom merged commit 87b6c70 into dev Jul 25, 2022
@ablaom ablaom deleted the predict-for-static branch July 25, 2022 03:47
This was referenced Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant