Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat LossFunctions = "0.9" and address breakage #898

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Apr 20, 2023

Closes: #896 #570

Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #898 (9603c64) into dev (4cb9ba7) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              dev     #898   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files          40       40           
  Lines        3567     3567           
=======================================
  Hits         3061     3061           
  Misses        506      506           
Impacted Files Coverage Δ
src/measures/loss_functions_interface.jl 73.21% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ablaom
Copy link
Member Author

ablaom commented Apr 20, 2023

Thanks @ToucheSir . FYI I am working on a major refactor of the MLJMeasures code, which will live in a separate package, which will better leverage MLUtils.jl. I'm considering dropping LossFunctions.jl altogether there (see this issue) and to just re-implement those functions. Given the infrastructure I have developed, this would be pretty simple. I'll also make the basic type-free scalar functions public.

@ablaom ablaom merged commit 8f3a29d into dev Apr 20, 2023
@ablaom ablaom deleted the loss-functions-0.9 branch April 20, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to LossFunctions.jl v0.9
3 participants