Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing healthcheck function due to platform inconsistency #35

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented Feb 14, 2024

#34

@pebeto pebeto linked an issue Feb 14, 2024 that may be closed by this pull request
@pebeto pebeto requested a review from ablaom February 14, 2024 07:03
@pebeto pebeto self-assigned this Feb 14, 2024
@pebeto pebeto added bug Something isn't working breaking labels Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (093c8df) to head (5755fe8).

Additional details and impacted files
@@             Coverage Diff             @@
##              dev       #35      +/-   ##
===========================================
+ Coverage   97.87%   100.00%   +2.12%     
===========================================
  Files           4         4              
  Lines          47        45       -2     
===========================================
- Hits           46        45       -1     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 🙏🏾

I agree, we should tag this as breaking. So this will be 0.4.0.

@ablaom
Copy link
Member

ablaom commented Feb 29, 2024

@pebeto Can you please merge and tag a new release when ready?

@pebeto pebeto merged commit fcf2bbc into dev Mar 4, 2024
4 checks passed
@pebeto pebeto deleted the 34-mlflow-health-endpoint-is-doutbful branch March 4, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlflow health endpoint is doutbful
2 participants