Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnivariateTimeTypeToContinuous transformer to builtins #245

Closed
wants to merge 15 commits into from

Commits on Apr 28, 2020

  1. Add minimal implementation of univariate case

    Carl Morris committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    84b1faa View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Remove unnecessary type parameter

    Carl Morris committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    a848050 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'venuur-add-timetype-continuous' into dev

    Carl Morris committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    8881832 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Add type compatibility checks and clean! method

    Carl Morris committed May 5, 2020
    Configuration menu
    Copy the full SHA
    3bcd534 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ab3257 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'venuur-add-timetype-continuous' into dev

    Carl Morris committed May 5, 2020
    Configuration menu
    Copy the full SHA
    bee3945 View commit details
    Browse the repository at this point in the history
  4. Fix typo in throw

    Carl Morris committed May 5, 2020
    Configuration menu
    Copy the full SHA
    6e01391 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'venuur-add-timetype-continuous' into dev

    Carl Morris committed May 5, 2020
    Configuration menu
    Copy the full SHA
    3abaa09 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Add basic test and export statement

    Carl Morris committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    ae99b26 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'dev' of https://github.com/alan-turing-institute/MLJMod…

    …els.jl into venuur-add-timetype-continuous
    Carl Morris committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    6744cc5 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Add tests and fix default constructor

    Fix default constructor case of Hour(24) when applied to a Date vector.
    Hour cannot be added to Date objects, so the step must be converted to
    Day, but because this is a change to the step hyper parameter it must be
    adjusted. Unfortunately, this case cannot be distinguished from a user
    supplied date, so a warning must be shown, which is non-ideal for a
    common default case.
    
    Alternatively we can add an extra internal variable to track whether a
    user supplied step is given and only warn on that case, but that is
    extra complexity I am avoiding for this commit.
    Carl Morris committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    f441e77 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9655add View commit details
    Browse the repository at this point in the history
  3. Merge branch 'venuur-add-timetype-continuous' into dev

    Carl Morris committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    775baaf View commit details
    Browse the repository at this point in the history
  4. Add missing backticks

    Carl Morris committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    3895228 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'venuur-add-timetype-continuous' into dev

    Carl Morris committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    a7da598 View commit details
    Browse the repository at this point in the history