Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload save and restore #208

Merged
merged 8 commits into from Mar 7, 2024
Merged

Overload save and restore #208

merged 8 commits into from Mar 7, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Mar 3, 2024

Resolves #207

@ablaom ablaom changed the title Overload save and restore Overload save and restore Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (da15fb3) to head (70445e7).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #208      +/-   ##
==========================================
+ Coverage   87.38%   87.42%   +0.03%     
==========================================
  Files          13       13              
  Lines         658      660       +2     
==========================================
+ Hits          575      577       +2     
  Misses         83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom requested a review from OkonSamuel March 4, 2024 00:02
@ablaom
Copy link
Member Author

ablaom commented Mar 4, 2024

@paulotrefosco Be great if you can confirm this MLJTuning.jl branch resolves your issue with wrapping XGBoost models in TunedModel.

You can add this branch to your environment with using Pkg; Pkg.add(name="MLJTuning", rev="save-restore")

test/tuned_models.jl Outdated Show resolved Hide resolved
Copy link
Member

@OkonSamuel OkonSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the minor change

@ablaom ablaom merged commit c081bd0 into dev Mar 7, 2024
4 checks passed
@ablaom ablaom mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overload save/restore to fix serialisation when atomic model has ephemeral fitresult
2 participants