Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create option to write CompactPerformanceEvaluation objects to history #215

Merged
merged 3 commits into from
May 6, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Apr 26, 2024

... and make that the default.

Requires:

and closes JuliaAI/MLJ.jl#1105

Technically breaks a change made a few patch releases ago, but doesn't actually effect the published API.

After this PR, you can specify compact_history=false in TunedModel(...) to get full PerformanceEvaluation objects written to the history. Otherwise these are CompactPerformanceEvaluation objects.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.53%. Comparing base (c597f27) to head (5143292).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #215   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files          13       13           
  Lines         666      666           
=======================================
  Hits          583      583           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom marked this pull request as ready for review May 6, 2024 03:24
@ablaom
Copy link
Member Author

ablaom commented May 6, 2024

@dpaetzel Any chance you could review this?

@dpaetzel
Copy link

dpaetzel commented May 6, 2024

I looked over the change set and didn't find anything out of place. Since the build passes the tests and those cover the new behaviour I guess this looks good to merge? 🙂

@ablaom
Copy link
Member Author

ablaom commented May 6, 2024

Thanks @dpaetzel for the prompt review 🙏🏾

@ablaom ablaom merged commit 8f0c036 into dev May 6, 2024
4 of 6 checks passed
@ablaom ablaom mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current performance evaluation objects, recently added to TunedModel histories, are too big
2 participants