Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for change in maxevals in gram.jl #41

Merged
merged 2 commits into from Mar 12, 2021
Merged

Allow for change in maxevals in gram.jl #41

merged 2 commits into from Mar 12, 2021

Conversation

GeorgAUT
Copy link
Collaborator

For evaluation of the boundary conditions. This may not be ideal - would be better if could extract maxevals from options..., but I could not get that to work.

For evaluation of the boundary conditions
@GeorgAUT GeorgAUT requested a review from daanhb March 12, 2021 12:06
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #41 (acaec6d) into master (65efd6b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   61.67%   61.67%           
=======================================
  Files          89       89           
  Lines        5584     5584           
=======================================
  Hits         3444     3444           
  Misses       2140     2140           
Impacted Files Coverage Δ
src/bases/dictionary/gram.jl 74.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65efd6b...937a418. Read the comment docs.

@GeorgAUT
Copy link
Collaborator Author

Excellent idea, the above is updated in this branch, should automatically merge through the pull request.

@daanhb daanhb merged commit 9a7376e into master Mar 12, 2021
@daanhb daanhb deleted the GeorgAUT-patch-1 branch July 24, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants