Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test for Normalization in cheb2leg and leg2cheb #203

Closed
jishnub opened this issue Mar 26, 2023 · 4 comments
Closed

Write test for Normalization in cheb2leg and leg2cheb #203

jishnub opened this issue Mar 26, 2023 · 4 comments

Comments

@jishnub
Copy link
Member

jishnub commented Mar 26, 2023

This used to work on v0.14

julia> cheb2leg([0.0, 1.0], normcheb=true)
2-element Vector{Float64}:
 0.0
 0.7978845608028654

but errors on v0.15

julia> cheb2leg([0.0, 1.0], normcheb=true)
ERROR: MethodError: no method matching th_cheb2leg(::Vector{Float64}; normcheb::Bool)

Closest candidates are:
  th_cheb2leg(::Any, ::Any...) got unsupported keyword argument "normcheb"
   @ FastTransforms ~/Dropbox/JuliaPackages/FastTransforms.jl/src/toeplitzhankel.jl:282

Stacktrace:
 [1] cheb2leg(::Vector{Float64}; z::Base.Pairs{Symbol, Bool, Tuple{Symbol}, NamedTuple{(:normcheb,), Tuple{Bool}}})
   @ FastTransforms ~/Dropbox/JuliaPackages/FastTransforms.jl/src/FastTransforms.jl:129
 [2] top-level scope
   @ REPL[29]:1

It would be good to get this working again

@dlfivefifty
Copy link
Member

Ah didn't know about that keyword. You can use FastTransforms.lib_cheb2leg to use the old version for now.

Note we the lib version's plan is expensive which is why we now default to th_cheb2leg, which has a better complexity plan, though applying the plan is slower so plan_cheb2leg currently defaults to the old version.

@dlfivefifty dlfivefifty changed the title Normalization not accepted anymore in cheb2leg and leg2cheb Write test for Normalization in cheb2leg and leg2cheb Mar 27, 2023
@dlfivefifty
Copy link
Member

This has been fixed by reverting to lib_cheb2leg (though back to the restrictions of small dimension).

I'm leaving this open as the tests should have picked this up.

dlfivefifty added a commit that referenced this issue Mar 27, 2023
@dlfivefifty
Copy link
Member

Actually I just did it based on your example.

@MikaelSlevinsky
Copy link
Member

Yes, apologies, there should have been tests for the normalization keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants