Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use transform for plotting #127

Merged
merged 4 commits into from
May 8, 2022
Merged

Use transform for plotting #127

merged 4 commits into from
May 8, 2022

Conversation

dlfivefifty
Copy link
Member

With this plotting uses the inverse Zernike transform so is not so bad anymore.

Note the only thing slow is that it is still using evaluation for the origin and the boundary.

@dlfivefifty
Copy link
Member Author

image

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #127 (46f15cd) into master (cf0d0ba) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   96.15%   96.21%   +0.05%     
==========================================
  Files           4        4              
  Lines         702      713      +11     
==========================================
+ Hits          675      686      +11     
  Misses         27       27              
Impacted Files Coverage Δ
src/disk.jl 98.18% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0d0ba...46f15cd. Read the comment docs.

@dlfivefifty dlfivefifty merged commit 63dc386 into master May 8, 2022
@dlfivefifty dlfivefifty deleted the dl/fastplot branch May 8, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant