Support logical indexing #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works great, thanks! Maybe open an issue regarding |
|
Sure: #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, logical indexing was only supported on a per-dimension basis. Julia array indexing also allows logical linear indexing, as well as logical indexing with the same dimensionality as the data (treated as linear). AxisArrays provided linear indexing for integers, but not for logicals. Now it supports all the logical indexing that Base supports.
One thing I noticed while making this PR is that linear indexing always produces one axis named
:col, whereas the first default index name is actually:row. But I think if we want to change that, that's another PR.Closes #110