to_index now throws an ArgumentException instead of an UndefVarError … #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when given repeated axes.
There is a TODO in indexing.jl asking whether or not AxisArrays should allow indexing with repeated axes. This PR does not make a decision about that, but on master the expected
ErrorException
is not thrown:In this PR, in addition to displaying the expected error message I've made it an
ArgumentError
rather than anErrorException
:I'll keep working my way towards a PR for
atvalue
as discussed earlier, I'm just trying to understand indexing better first.