Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map and map! #71

Merged
merged 1 commit into from
Mar 24, 2017
Merged

map and map! #71

merged 1 commit into from
Mar 24, 2017

Conversation

GordStephen
Copy link

Right now map returns a normal Array, discarding the axis data - this PR would change that to preserve axis information, and require that values only be mapped from multiple AxisArrays if they have identical axes. As discussed in #54, broadcasting with semantic axes is a bit complicated, but map seems less controversial?

IIRC back in 0.4 map actually preserved the axis data, I guess something in the AbstractArray implementation changed with 0.5? I'm assuming that explicit mapping functions are the best way to regain this behaviour, but if there's a lower-level interface that could be implemented to achieve the same end, that would probably be the more elegant solution.

Also, checking for matchingdims was using size previously, which caused issues when used with things like OffsetArrays - this addresses that as well.

@timholy
Copy link
Member

timholy commented Mar 24, 2017

This seems great, thanks for doing it!

@timholy timholy merged commit c56dc40 into master Mar 24, 2017
@timholy timholy deleted the gs/map branch March 24, 2017 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants