Support IdentityUnitRange #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh bless you. I was just trying to find time in my schedule to do this myself to fix PkgEval in preparation for a 1.1 RC. Turns out this fix is smaller than I expected. Thank you! |
mbauman
approved these changes
Dec 11, 2018
| @@ -3,6 +3,11 @@ VERSION < v"0.7.0-beta2.199" && __precompile__() | |||
| module OffsetArrays | |||
|
|
|||
| using Base: Indices, tail, @propagate_inbounds | |||
| @static if !isdefined(Base, :IdentityUnitRange) | |||
| const IdentityUnitRange = Base.Slice | |||
There was a problem hiding this comment.
I really like how this is now a defined OffsetArrays name. Nice.
Merged
27 tasks
johnnychen94
added a commit
to Evizero/Augmentor.jl
that referenced
this pull request
Dec 16, 2019
* maybe_copy doesn't explain its usage * replace Slice by OffsetArrays.IdentityUnitRange JuliaArrays/OffsetArrays.jl#62
johnnychen94
added a commit
to Evizero/Augmentor.jl
that referenced
this pull request
Jan 29, 2020
* add Project.toml * update test for cache and minor fix * update test for rotation and minor fix * update flipdm to reverse JuliaLang/julia#26369 * update test for crop and minor fix * update test for resize * update test for scale and minor fix * update test for zoom and minor fix * WIP: update test for distortion and minor fix * update test for either and minor fix * fix pipeline test * update summary reference for distortedview * WIP: fix tests for augment and operations * drop julia 0.7 and update CI * use FileIO v1.1.0 JuliaIO/FileIO.jl#245 * add 1.x tests to CI * revert back unnecessary changes * test windows in travis * fix randomly failed test cases for inacuraccy reasons * update to julia 1.1 * maybe_copy doesn't explain its usage * replace Slice by OffsetArrays.IdentityUnitRange JuliaArrays/OffsetArrays.jl#62 * update to julia 1.2 -- part I * WIP: update to julia 1.2 -- part II detect some type instable test cases, only the outmost wrapper is instable here * unify how types are displayed Only meta operations such as Either, Pipeline doesn't have Agumentor prefix * add more test versions * move safe_rand to compat.jl rand is thread-safe in julia 1.3 * don't allow failures for julia 1.3 * fix commit "WIP: update 1.0" * use explicit and intuitive CartesianIndex(1, 1) * add method specialization for tweight * allow FileIO 1.2 * fix type instability for Either * update reference for FixedPointNumbers v0.7 * try: relax equality check for scale * restore test cases in tst_scale.jl * Revert "add method specialization for tweight" This reverts commit a698382. * Augmentor v0.6.0-pre
johnnychen94
added a commit
to Evizero/Augmentor.jl
that referenced
this pull request
Jan 29, 2020
* add Project.toml * update test for cache and minor fix * update test for rotation and minor fix * update flipdm to reverse JuliaLang/julia#26369 * update test for crop and minor fix * update test for resize * update test for scale and minor fix * update test for zoom and minor fix * WIP: update test for distortion and minor fix * update test for either and minor fix * fix pipeline test * update summary reference for distortedview * WIP: fix tests for augment and operations * drop julia 0.7 and update CI * use FileIO v1.1.0 JuliaIO/FileIO.jl#245 * add 1.x tests to CI * revert back unnecessary changes * test windows in travis * fix randomly failed test cases for inacuraccy reasons * update to julia 1.1 * maybe_copy doesn't explain its usage * replace Slice by OffsetArrays.IdentityUnitRange JuliaArrays/OffsetArrays.jl#62 * update to julia 1.2 -- part I * WIP: update to julia 1.2 -- part II detect some type instable test cases, only the outmost wrapper is instable here * unify how types are displayed Only meta operations such as Either, Pipeline doesn't have Agumentor prefix * add more test versions * move safe_rand to compat.jl rand is thread-safe in julia 1.3 * don't allow failures for julia 1.3 * fix commit "WIP: update 1.0" * use explicit and intuitive CartesianIndex(1, 1) * add method specialization for tweight * allow FileIO 1.2 * fix type instability for Either * update reference for FixedPointNumbers v0.7 * try: relax equality check for scale * restore test cases in tst_scale.jl * Revert "add method specialization for tweight" This reverts commit a698382. * Augmentor v0.6.0-pre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were breaking on nightly, see e.g., https://travis-ci.org/JuliaArrays/OffsetArrays.jl/jobs/466269867.
CC @mbauman