Skip to content

Commit

Permalink
Fix broken test (#48)
Browse files Browse the repository at this point in the history
* Fix broken test
It seems like we were previously testing for behaviour that didn't match arrays...
* Move julia compat up to 1.9 so that we can follow latest DimensionalData
* Only test on Julia 1.9+
  • Loading branch information
sefffal committed Jun 12, 2024
1 parent 5153098 commit ca1633e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
version:
- '1.6' # Minimum Julia version that the package supports.
- '1.9' # Minimum Julia version that the package supports.
- '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia.
- 'nightly'
os:
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RecipesBase = "1.2"
Statistics = "1"
Tables = "1.7"
WCS = "0.6"
julia = "^1.6.0"
julia = "1.9.0"

[extras]
FITSIO = "525bcba6-941b-5504-bd06-fd0dc1a4d2eb"
Expand Down
17 changes: 2 additions & 15 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -301,21 +301,8 @@ end
img = AstroImage(arr1)

# https://github.com/JuliaAstro/AstroImages.jl/issues/32
@test reverse(img, dims=1) == reverse(img) == [
7 8 9
4 5 6
1 2 3
]
@test reverse(img, dims=2) == [
3 2 1
6 5 4
9 8 7
]
@test reverse(img, dims=(1,2)) == [
9 8 7
6 5 4
3 2 1
]
@test reverse(img, dims=1) == reverse(arr1,dims=1)
@test reverse(img) == reverse(arr1)


# https://github.com/JuliaAstro/AstroImages.jl/issues/33
Expand Down

0 comments on commit ca1633e

Please sign in to comment.